Skip to content

[18.0][ADD] pos_barcode_rule_priced_with_change_rate #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 9, 2025
Merged

[18.0][ADD] pos_barcode_rule_priced_with_change_rate #1346

merged 3 commits into from
Apr 9, 2025

Conversation

trisdoan
Copy link
Contributor

@trisdoan trisdoan commented Mar 27, 2025 •
edited
Loading

Result

This is how I setup a demo

  1. Configure "Change rate for barcode nomenclature" to be 10.00
  2. Setup a Barcode rule
    • With the type Priced Product with change Rate
    • My example barcode pattern is: 24{NN}: NN is a price
  3. Use scanner in POS
    • I scan 2415 => Meaning the price for the product is $15.00
    • Result of the demo is with Tax $0.23
pos.webm

sebduch73
sebduch73 reviewed Apr 8, 2025
View reviewed changes
Copy link

@sebduch73 sebduch73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the module and everything is ok. Can you push the PR?

@trisdoan
Copy link
Contributor Author

trisdoan commented Apr 9, 2025

Hello @Camille0907 @ivantodorovich , how does it look?

ivantodorovich
ivantodorovich approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot migration pos_barcode_rule_priced_with_change_rate
/ocabot merge nobump

LG, thanks!

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Apr 9, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 9, 2025
Open
14 tasks
@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-1346-by-ivantodorovich-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b85d09a into OCA:18.0 Apr 9, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e9059e3. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebduch73 sebduch73 sebduch73 left review comments

@ivantodorovich ivantodorovich ivantodorovich approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.
5 participants
@trisdoan @OCA-git-bot @ivantodorovich @sebduch73 @Camille0907