-
-
Notifications
You must be signed in to change notification settings - Fork 631
[18.0][MIG] pos_display_total_quantity: Migration to 18.0 #1352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] pos_display_total_quantity: Migration to 18.0 #1352
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the module and everything is ok. Can you push the PR?
Hello @henrybackman @ivantodorovich , how does it look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot migration pos_display_total_quantity
@trisdoan @ivantodorovich Apparently we have a problem with the merge, can you take a look? thx |
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
@trisdoan can you rebase and remove the temporary test dependencies, seeing that the dependant PRs are already merged? |
@ivantodorovich your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-1352-by-ivantodorovich-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
Adds total quantity in POS total summary. This helps to verify that all items have been scanned.
b00b1fd
to
e1db3b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
functionally tested
This PR has the |
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 61c9784. Thanks a lot for contributing to OCA. ❤️ |
Note
Result