Skip to content

[18.0][MIG] pos_display_total_quantity: Migration to 18.0 #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 11, 2025

Conversation

trisdoan
Copy link
Contributor

@trisdoan trisdoan commented Apr 1, 2025

Copy link

@sebduch73 sebduch73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the module and everything is ok. Can you push the PR?

@trisdoan
Copy link
Contributor Author

trisdoan commented Apr 9, 2025

Hello @henrybackman @ivantodorovich , how does it look?

Copy link
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot migration pos_display_total_quantity

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Apr 9, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 9, 2025
14 tasks
@sebduch73
Copy link

@trisdoan @ivantodorovich Apparently we have a problem with the merge, can you take a look? thx

@ivantodorovich
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-1352-by-ivantodorovich-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 10, 2025
Signed-off-by ivantodorovich
@ivantodorovich
Copy link
Contributor

@trisdoan can you rebase and remove the temporary test dependencies, seeing that the dependant PRs are already merged?

@OCA-git-bot
Copy link
Contributor

@ivantodorovich your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-1352-by-ivantodorovich-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

henrybackman and others added 3 commits April 11, 2025 08:45
@trisdoan trisdoan force-pushed the 18.0-mig-pos_display_total_quantity branch from b00b1fd to e1db3b2 Compare April 11, 2025 01:45
@trisdoan trisdoan requested a review from ivantodorovich April 11, 2025 01:45
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functionally tested

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@ivantodorovich
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-1352-by-ivantodorovich-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 10d0034 into OCA:18.0 Apr 11, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 61c9784. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants