-
-
Notifications
You must be signed in to change notification settings - Fork 631
[13.0][MIG] pos_order_mgmt #584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When the PoS is using fiscal positions it can lead to errors when computing the reprinted ticket value because the tax mapping function computes them from the current order instead of from the one belonging to the line. So we set our loaded order temporarily as the selected one just to bring it back to the current one after it's printed.
Currently translated at 100.0% (20 of 20 strings) Translation: pos-11.0/pos-11.0-pos_order_mgmt Translate-URL: https://translation.odoo-community.org/projects/pos-11-0/pos-11-0-pos_order_mgmt/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-11.0/pos-11.0-pos_order_mgmt Translate-URL: https://translation.odoo-community.org/projects/pos-11-0/pos-11-0-pos_order_mgmt/
- Fix search clear button - Refactor load_order and actions This refactors load_data into two functions: load_order_data and load_order_from_data. Also, when executing actions, instead of sending the order as an argument, only the order_data will be sent. The action method is responsible for generating the order data (if that's what it needs) All the refund logic has been extracted from the various methods, and it's now in action_return. Now, returns have a specific 'Refund XXXX' name. - IMP Allow to duplicate done orders from the POS - IMP filter by customer name, too, when searching
[FIX] compatibility with pos_restaurant OCA#339 cortesy @carlosDomatix [FIX] add _compute_refund_order_qty [ADD] pos order view form. Add links to original returned order and refund orders. [IMP] when refunding an order via the 'Refund' button in back office, set the correct returned_order_id. [IMP] Add helper on each button [ADD] python test [REF] JS remove useless code [REF] Python remove useless code [FIX] remove bad oldname [FIX] remove gap in bill display, when it is a refund [FIX] when reprinting a bill, the returned order name is displayed, if any [FIX] JS lint, with OCA eslint file [ADD] french translation
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_order_mgmt Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_order_mgmt/
…n order, if the user refreshes the browser the order will load again. And this will happen for every previously printed order in the session.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_order_mgmt Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_order_mgmt/
…right the amount and make it's header take less space
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_order_mgmt Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_order_mgmt/
@legalsylvain @chienandalu could you review? Thanks! @trinanda I've reused some of the changes of your PR, I should incluye you in the |
@dalonsod Yes, although I'll have to test it in my local as runbot isn't working currently |
hello @chienandalu have you tested it locally? Unfortunately runbot is still unavailable. Thanks! |
I'm so sorry. I didn't have the time yet :/ I'll try to rebuild the runbot though |
When I try to merge this pr with current version with
I've got an error:
So I think there is something wrong with your history. |
Can you do a rebase? |
@cubells maybe I'm doing something wrong, but I've made |
Have you run |
Ok, did it and git told me that everything up-to-date |
@legalsylvain @chienandalu since PR creation it's been impossible to test it on runbot, at least for me. I don't think if it's a problem of this PR, or a general issue of this repo (runbot too busy). Is this a normal situation, or could it be solved? Thanks! |
Now it's working, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
LGTM
Code review and test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks to have ported this must have module.
This PR has the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested at last 😄 Thanks!
/ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at ea68372. Thanks a lot for contributing to OCA. ❤️ |
Supersedes #487 due to inactivity