Skip to content

[13.0] [mig] pos_fix_search_limit #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
May 8, 2021
Merged

[13.0] [mig] pos_fix_search_limit #625

merged 14 commits into from
May 8, 2021

Conversation

dsolanki-initos
Copy link
Contributor

No description provided.

@dsolanki-initos dsolanki-initos mentioned this pull request Apr 16, 2021
Open
15 tasks
@dsolanki-initos
Copy link
Contributor Author

@legalsylvain can you please review the PR?

@legalsylvain
Copy link
Contributor

Hi. I think that @hpar original author and @cvinh (migration to 11.0), @wpichler (migration to 12.0) could have a more interesting point of view regarding this migration.

@chienandalu chienandalu added this to the 13.0 milestone Apr 26, 2021
@dsolanki-initos
Copy link
Contributor Author

@wpichler It would be great if you could add reviews here.

fshah-initos
fshah-initos approved these changes May 7, 2021
View reviewed changes
Copy link
Contributor

@fshah-initos fshah-initos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Code and functional review.

@dreispt
Copy link
Member

dreispt commented May 8, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-625-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0d90681 into OCA:13.0 May 8, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 697897e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fshah-initos fshah-initos fshah-initos approved these changes

Assignees
No one assigned
Labels
merged 🎉 needs review
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.