[14.0][mig]pos_warning_exiting #664

hkapatel-initos · 2021-06-03T09:41:07Z

No description provided.

…ting from Point of sale Front office UI Co-authored-by: Iván Todorovich <ivan.todorovich@gmail.com>

legalsylvain

Hi. Thanks for porting this module !

This seems WIP. you added a new full file Chrome.js that is not included in the loaded files.

Note : could you rename into chrome.js BTW ?

hkapatel-initos · 2021-06-03T09:59:52Z

Hi. Thanks for porting this module !

This seems WIP. you added a new full file Chrome.js that is not included in the loaded files.

Note : could you rename into chrome.js BTW ?

yes, I have renamed the file.

dsolanki-initos

Looks Good To Me

hkapatel-initos · 2021-06-10T05:47:54Z

@ivantodorovich can you please review this PR?

ivantodorovich · 2021-06-10T12:11:58Z

pos_warning_exiting/__manifest__.py

@@ -6,17 +6,13 @@
    "name": "Point Of Sale - Warning on Exiting",
    "summary": "Add warning at exiting the PoS front office UI"
    " if there are pending draft orders",
-    "version": "12.0.1.0.1",
+    "version": "14.0.1.0.1",


Version should be 14.0.1.0.0

ivantodorovich · 2021-06-10T12:14:34Z

pos_warning_exiting/static/src/js/chrome.js

+odoo.define("pos_warning_exiting.Chrome", function (require) {
+    "use strict";
+
+    const {_t} = require("web.core");


You can just use this.env._t and avoid this requirement

Not blocking though

ivantodorovich · 2021-06-10T12:18:38Z

pos_warning_exiting/static/src/js/chrome.js

+                    const reason = this.env._t(
+                        "You have some draft unpaid orders." +
+                            " You can exit temporarily the Point of Sale, but you" +
+                            " will loose that orders if you close the session: " +
+                            draft_orders_description.join(", ")
+                    );


Blocking.

This won't ever be translated because you're including draft_orders_description into the translatable string.

You need to do something like this:

const message = this.env._t( "You have some draft unpaid orders. " + "You can exit temporarily the Point of Sale, but you " + "will loose that orders if you close the session: " ); const reason = message + draft_orders_description.join(", ");

ivantodorovich · 2021-06-10T12:29:49Z

pos_warning_exiting/static/src/js/chrome.js

+                var self = this;
+                const draft_orders_description = [];
+                const order_jsons = this.env.pos.db.get_unpaid_orders();
+
+                if (order_jsons.length) {
+                    order_jsons.forEach(function (order_json) {
+                        if (
+                            order_json.pos_session_id === self.env.pos.pos_session.id &&
+                            order_json.lines.length
+                        ) {
+                            var order_description =
+                                _t("Order #") + order_json.sequence_number;
+                            // Lazy depedency to pos_restaurant
+                            // to display table information
+                            if (order_json.table) {
+                                order_description +=
+                                    _t(" - Table: ") + order_json.table.name;
+                            }
+                            draft_orders_description.push(order_description);
+                        }
+                    });
+                }


Not blocking here but I would do something like this here

const unpaidOrders = this.env.pos.db.get_unpaid_orders(); const toLoseOrders = unpaidOrders.filter( order => order.pos_session_id === this.env.pos.session_id.id && order.lines.length ); if (toLoseOrders.length) { const orderDescriptions = toLoseOrders.map(order => { let description = this.env._t("Order #") + order.sequence_number; // Lazy dependency to pos_restaurant to display table information if (order.table) { description += this.env._t(" - Table: ") + order.table.name; } return description; }) // .. you know the rest }

by using arrow functions you avoid having to define and use self, and you achieve a more readable result IMO

hkapatel-initos · 2021-06-16T04:59:52Z

@ivantodorovich Thanks for the review suggestions are implemented you can re-review it

ivantodorovich

LGTM 👍

Thanks a lot for taking the time to do this

hkapatel-initos · 2021-06-18T10:12:34Z

@HaraldPanten can u please review this pr?

HaraldPanten

Functional review 👍

hkapatel-initos · 2021-06-23T09:06:12Z

@brendapaniagua can u please review this pr?

hkapatel-initos · 2021-06-23T09:25:57Z

Hi. Thanks for porting this module !

This seems WIP. you added a new full file Chrome.js that is not included in the loaded files.

Note : could you rename into chrome.js BTW ?

Thanks for the review suggestions are implemented you can re-review it

ivantodorovich · 2021-06-23T20:09:58Z

/ocabot merge nobump

OCA-git-bot · 2021-06-23T20:10:09Z

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-664-by-ivantodorovich-bump-nobump, awaiting test results.

OCA-git-bot · 2021-06-23T20:19:38Z

Congratulations, your PR was merged at 98a3211. Thanks a lot for contributing to OCA. ❤️

legalsylvain and others added 6 commits June 3, 2021 12:48

[ADD] pos_warning_exiting : new module to add extra checks before exi…

23ba2da

…ting from Point of sale Front office UI Co-authored-by: Iván Todorovich <ivan.todorovich@gmail.com>

[UPD] Update pos_warning_exiting.pot

cbb0d00

[UPD] README.rst

91dc695

[ADD] icon.png

b93b4e1

pos_warning_exiting 12.0.1.0.1

4fa1307

[IMP] pos_warning_exiting: black, isort, prettier

3d35c06

legalsylvain requested changes Jun 3, 2021

View reviewed changes

hkapatel-initos changed the title ~~[14.0][mig]pos_warning_exiting~~ [wip][14.0][mig]pos_warning_exiting Jun 3, 2021

hkapatel-initos force-pushed the 14.0-mig-pos_warning_exiting branch 3 times, most recently from 2b47360 to b30282a Compare June 4, 2021 07:18

dsolanki-initos approved these changes Jun 9, 2021

View reviewed changes

hkapatel-initos force-pushed the 14.0-mig-pos_warning_exiting branch from b30282a to 90822ae Compare June 10, 2021 04:52

hkapatel-initos changed the title ~~[wip][14.0][mig]pos_warning_exiting~~ [14.0][mig]pos_warning_exiting Jun 10, 2021

hkapatel-initos requested a review from legalsylvain June 10, 2021 05:45

ivantodorovich requested changes Jun 10, 2021

View reviewed changes

hkapatel-initos force-pushed the 14.0-mig-pos_warning_exiting branch from 90822ae to 3a996a3 Compare June 14, 2021 07:13

hkapatel-initos requested a review from ivantodorovich June 14, 2021 07:14

hkapatel-initos force-pushed the 14.0-mig-pos_warning_exiting branch from 3a996a3 to ee15733 Compare June 14, 2021 07:34

hkapatel-initos mentioned this pull request Jun 14, 2021

Migration to version 14.0 #543

Open

16 tasks

hkapatel-initos force-pushed the 14.0-mig-pos_warning_exiting branch from ee15733 to 1f373cb Compare June 16, 2021 04:35

[MIG] 14.0-mig-pos_warning_exiting: Migration to 14.0

08d86c2

hkapatel-initos force-pushed the 14.0-mig-pos_warning_exiting branch from 1f373cb to 08d86c2 Compare June 16, 2021 04:46

ivantodorovich approved these changes Jun 16, 2021

View reviewed changes

HaraldPanten approved these changes Jun 23, 2021

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Jun 23, 2021

OCA-git-bot merged commit d120638 into OCA:14.0 Jun 23, 2021

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jun 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0][mig]pos_warning_exiting #664

[14.0][mig]pos_warning_exiting #664

hkapatel-initos commented Jun 3, 2021

legalsylvain left a comment •

edited

Loading

hkapatel-initos commented Jun 3, 2021

dsolanki-initos left a comment

hkapatel-initos commented Jun 10, 2021

ivantodorovich Jun 10, 2021

ivantodorovich Jun 10, 2021

ivantodorovich Jun 10, 2021

ivantodorovich Jun 10, 2021

hkapatel-initos commented Jun 16, 2021

ivantodorovich left a comment

hkapatel-initos commented Jun 18, 2021

HaraldPanten left a comment

hkapatel-initos commented Jun 23, 2021

hkapatel-initos commented Jun 23, 2021

ivantodorovich commented Jun 23, 2021

OCA-git-bot commented Jun 23, 2021

OCA-git-bot commented Jun 23, 2021

[14.0][mig]pos_warning_exiting #664

[14.0][mig]pos_warning_exiting #664

Conversation

hkapatel-initos commented Jun 3, 2021

legalsylvain left a comment • edited Loading

Choose a reason for hiding this comment

hkapatel-initos commented Jun 3, 2021

dsolanki-initos left a comment

Choose a reason for hiding this comment

hkapatel-initos commented Jun 10, 2021

ivantodorovich Jun 10, 2021

Choose a reason for hiding this comment

ivantodorovich Jun 10, 2021

Choose a reason for hiding this comment

ivantodorovich Jun 10, 2021

Choose a reason for hiding this comment

ivantodorovich Jun 10, 2021

Choose a reason for hiding this comment

hkapatel-initos commented Jun 16, 2021

ivantodorovich left a comment

Choose a reason for hiding this comment

hkapatel-initos commented Jun 18, 2021

HaraldPanten left a comment

Choose a reason for hiding this comment

hkapatel-initos commented Jun 23, 2021

hkapatel-initos commented Jun 23, 2021

ivantodorovich commented Jun 23, 2021

OCA-git-bot commented Jun 23, 2021

OCA-git-bot commented Jun 23, 2021

legalsylvain left a comment •

edited

Loading