-
-
Notifications
You must be signed in to change notification settings - Fork 631
[15.0][MIG] pos_fixed_discount #891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you check pre-commit please, seems red?
/ocabot migration pos_fixed_discount |
/ocabot rebase |
Currently translated at 100.0% (5 of 5 strings) Translation: pos-12.0/pos-12.0-pos_fixed_discount Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_fixed_discount/es/
Congratulations, PR rebased to 15.0. |
182093e
to
a8763dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM!
This PR has the |
@@ -17,7 +17,7 @@ odoo.define("pos_fixed_discount.FixedDiscountButton", function (require) { | |||
startingValue: 0, | |||
}); | |||
if (confirmed) { | |||
var val = Math.round(Math.max(0, Math.min(100, parseFloat(payload)))); | |||
var val = parseFloat(payload); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the rationale for this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it comes from #888
Either it is needed to be merged first or we need to migrate "as is" and than apply this patch with a new PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah - it is from #888 I had it applied in local repo and forgot about it when doing the migration so the proper way should be as @isserver1 suggests...
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Standard migration.