[FIX][web_responsive] Long-named multicompanies nice in XS #688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
requested changes
Aug 8, 2017
web_responsive/__manifest__.py
Outdated
| @@ -6,7 +6,7 @@ | |||
| "name": "Web Responsive", | |||
| "summary": "It provides a mobile compliant interface for Odoo Community " | |||
| "web", | |||
| "version": "10.0.1.0.0", | |||
| "version": "10.0.1.0.1", | |||
There was a problem hiding this comment.
This requires to update the module, so put 10.0.1.1.0.
There was a problem hiding this comment.
Are you sure? I think that's not needed to update a client-side qweb template, isn't it?
There was a problem hiding this comment.
Well, I'm not sure either, but anyway, it doesn't hurt
|
What about the other request? |
|
Ah sorry, I think it's more consistent if we display the same icon in all sizes. This way when using XS viewport you are already familiar with that icon and its meaning. |
|
Well, there are other elements that change notably when they are in small size, and it's very easy to discover for what is the building with the dropdown arrow, so I prefer to keep big screen without that icon. |
|
I feel that's anti-UX, but will do. |
pedrobaeza
approved these changes
Aug 10, 2017
|
@lasley @chienandalu please review |
chienandalu
approved these changes
Aug 10, 2017
|
Bit late to the party, but 👍 ! |
angelmoya
pushed a commit
to PESOL/web
that referenced
this pull request
Oct 6, 2017
yaniaular
pushed a commit
to vauxoo-dev/web
that referenced
this pull request
May 14, 2018
yaniaular
pushed a commit
to vauxoo-dev/web
that referenced
this pull request
May 14, 2018
yajo
added a commit
to Tecnativa/web
that referenced
this pull request
Oct 5, 2018
yajo
added a commit
to Tecnativa/web
that referenced
this pull request
Dec 10, 2018
tschanzt
pushed a commit
to camptocamp/web
that referenced
this pull request
Jun 19, 2019
Tardo
pushed a commit
to Tecnativa/web
that referenced
this pull request
Sep 30, 2019
Tardo
pushed a commit
to Tecnativa/web
that referenced
this pull request
Oct 13, 2019
pierre-pizzetta
pushed a commit
to pierre-pizzetta/web
that referenced
this pull request
Oct 17, 2020
SplashS
pushed a commit
to SplashS/web
that referenced
this pull request
Feb 11, 2021
SplashS
pushed a commit
to SplashS/web
that referenced
this pull request
Mar 17, 2021
SplashS
pushed a commit
to SplashS/web
that referenced
this pull request
Oct 21, 2021
SplashS
pushed a commit
to SplashS/web
that referenced
this pull request
Nov 15, 2021
bvanjeelharia
pushed a commit
to bvanjeelharia/web
that referenced
this pull request
Feb 6, 2023
bvanjeelharia
pushed a commit
to bvanjeelharia/web
that referenced
this pull request
Feb 6, 2023
bvanjeelharia
pushed a commit
to bvanjeelharia/web
that referenced
this pull request
Feb 7, 2023
bvanjeelharia
pushed a commit
to bvanjeelharia/web
that referenced
this pull request
Mar 1, 2023
TesaLazarenko
pushed a commit
to TesaLazarenko/oca_web
that referenced
this pull request
Nov 17, 2023
davidtranhp
pushed a commit
to davidtranhp/web
that referenced
this pull request
Feb 7, 2024
davidtranhp
pushed a commit
to davidtranhp/web
that referenced
this pull request
Feb 7, 2024
kobros-tech
pushed a commit
to kobros-tech/web
that referenced
this pull request
Dec 23, 2024
chaule97
pushed a commit
to chaule97/web
that referenced
this pull request
Jan 14, 2025
kobros-tech
pushed a commit
to kobros-tech/web
that referenced
this pull request
Jan 27, 2025
chaule97
pushed a commit
to chaule97/web
that referenced
this pull request
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch:
After it:
@Tecnativa