-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch partial #106
Fetch partial #106
Conversation
Closing as this was included with #94. |
Need to adapt according to #106 (comment) |
Best to wait for @VolkerHartmann, it's not a high priority issue, concerns only the validators AIFAICS. In the end, it cannot be an error if that rule is broken because real data is messy. |
Exactly. But would be good if validation does catch this. IME most real data is messy ;) |
@cneud @kba do you still want to adapt this with @VolkerHartmann no longer available? |
@EEngl52 This has implications on spec (bagit), so we should not close without a solution (even if not currently worked on). |
I don't see the use case for the I think there are other areas that are under- or unspecified that should be a much higher priority, such as the question how we can map back the relative filenames to HTTP URL for DFG Viewer compatibility or how we integrate a future workflow engine/parallelization setup with provenance etc. |
100% ACK, but before closing here we should probably still mention this in the relating docs and what about the validation? |
You're right, in fact I think we should set `Allow-Fetch.txt: false in the bagit profile and remove any mention of it and partial OCRD-ZIP. BTW the proposed change made it into the spec anyway and has been for two years. I think the validation is actually easier without fetch.txt because WYSIWYG, no network problems interfering. |
Is this related to OCR-D/core#323 by any chance? |
Yes and by extension to OCR-D/core#176 |
Since afaict OCR-D/core#323 is unaffected, this should also be closed with #182. |
Superseded by #182 |
Unfortunately all files have to be fetched to validate bag due to specification of kunze!
Only the last (two?) commits please.