Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openapi: Add requestBody to runWorkflow #220

Merged
merged 2 commits into from
Aug 16, 2022
Merged

openapi: Add requestBody to runWorkflow #220

merged 2 commits into from
Aug 16, 2022

Conversation

joschrew
Copy link
Contributor

Currently, I think, we only need the workspace_id (and the workflow_id provided in the path) to run a workflow. I think this is always required for other implementers as well. Please correct me if I am wrong. But I think that it is likely, that we or other implementers may encounter another parameter needed, like the starting file-grp for example. Because of that, I decided to add the parameters section like in processorArgs. I think this gives more flexibility to the implementers. Because I am not too sure about that please don't hesitate to comment if you have another opinion on that.

@joschrew
Copy link
Contributor Author

I am unsure about the description but couldn't find a better one

Copy link
Member

@kba kba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the description is clear enough too IMHO.

@kba kba merged commit 5e0932e into OCR-D:master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants