Skip to content

Implementation of mass_balance_check() and energy_balance_check() trait functions in blocks module #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 11, 2024

Conversation

bhargavakula01
Copy link
Collaborator

For this PR I have implemented basic functionality for the mass_balance_check() and energy_balance_check() trait functions for the Mixer object in "oscps-lib/src/blocks.rs".

Essentially these two functions will get different of IN - OUT and make sure that is lower than a tolerance. If TRUE, then it is in steady state. if FALSE, then it means that it is still in the dynamic state.

@bhargavakula01 bhargavakula01 added the enhancement New feature or request label Aug 11, 2024
Copy link
Collaborator

@At11011 At11011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider implementing relative tolerance later on.

@At11011 At11011 merged commit 0de170f into develop Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants