-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test running with something other than :none optmisations #17
Conversation
This is for fixing #16, I hope I can find a solution. When you run with So clearly the namespace resolution is totally different as soon as you enable optimisations. My hunch is that the generated |
So, progress. If you want to use any optimisation level other than
This should be enough to get it to run but it seems like it only works the first time. On the second run it complains about not being able to find the test namespaces which is pretty weird. Using advanced compilation seems to change a lot about the build cycle, maybe we can't get around this? Maybe since this is sort of an edge case these caveats are okay and they just need documenting? If you ran Care to try it out, @henryw374? |
Hi, thanks for looking into this.
with whitespace Optimization, nothing gets compiled or run.
With simple and advanced , things now get compiled, but then there is an
error where a foreign lib does not appear to have been loaded.... yet to
work out why.
…On Fri, Oct 19, 2018 at 6:57 PM Oliver Caldwell ***@***.***> wrote:
So, progress. If you want to use any optimisation level other than :none
you must:
- Add cljs-test-runner-out to your path so the compiler can find the
gen.test-runner namespace.
- Ensure that the cljs-test-runner-out directory exists *before*
running the program otherwise I think the JVM drops the path from the path
list.
This should be enough to get it to run *but* it seems like it only works
the first time. On the second run it complains about not being able to find
the test namespaces which is pretty weird. Using advanced compilation seems
to change a *lot* about the build cycle, maybe we can't get around this?
Maybe since this is sort of an edge case these caveats are okay and they
just need documenting? If you ran rm -rf cljs-test-runner-out && mkdir
cljs-test-runner-out before each run I think it'd work fine on this
branch.
Care to try it out, @henryw374 <https://github.com/henryw374>?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#17 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC7ZDO7VvM05jRb0eTTukLf2agkDnE-Mks5umhKhgaJpZM4Xw3Ep>
.
--
@henryw374
|
Have you added all of the externs? I can take another look, I had this working fine for me with advanced, make sure your test ClojureScript / JS actually compiles properly with advanced. Try |
In my test harness, I haven't tried with any foreign libs though... |
Yes, "optimisations" not "optimizations"
Glares in British 🇬🇧