Fix: Enhance robustness and clarity in kg-solver components #548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses several issues identified during a code analysis, focusing on improving the robustness, error handling, and clarity of various components within the KAG solver.
The following changes have been made:
KAGIterativePlanner:
is_static()
method to returnFalse
, aligning with its iterative behavior.KAGRetrievedResponse:
to_string()
method's docstring, as the error was not present in the code.KAGStaticPlanner:
finish_judger
error handling: If the LLM call to judge the answer fails, it now logs a warning and returnsFalse
(treating the answer as potentially bad) instead of defaulting toTrue
.ChunkRetrievedExecutor:
name
field in its schema dictionary from "Retriever" to "ChunkRetriever" to better differentiate it from other retriever executors likeKagHybridExecutor
.PyBasedMathExecutor:
subprocess.run()
call within therun_py_code
function. This prevents indefinite hangs from long-running or stuck Python scripts generated by the LLM. Includes handling forsubprocess.TimeoutExpired
.DefaultStaticPlanningPrompt:
parse_response
method: Implemented more robust JSON decoding and structural validation for the LLM-generated DAG plan. It now raises more descriptiveValueError
exceptions, including details of the malformed data, whenKeyError
orTypeError
occurs during task creation from the DAG, aiding in debugging.