Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:lang_specific_skills_list #662

Merged
merged 3 commits into from
Mar 13, 2025
Merged

feat:lang_specific_skills_list #662

merged 3 commits into from
Mar 13, 2025

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Mar 13, 2025

Summary by CodeRabbit

  • New Features
    • Expanded optional dependencies to include additional language-specific skills for enhanced multi-language support.
    • Introduced skill configurations for Catalan, English, and Portuguese, enabling broader functionality during installation.
    • Updated the build process to integrate these new language features for an improved user experience.

Copy link

coderabbitai bot commented Mar 13, 2025

Warning

Rate limit exceeded

@github-actions[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 21 minutes and 20 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between f7baf56 and 9a552bb.

📒 Files selected for processing (5)
  • .github/workflows/build_tests.yml (1 hunks)
  • requirements/skills-ca.txt (1 hunks)
  • requirements/skills-en.txt (1 hunks)
  • requirements/skills-pt.txt (1 hunks)
  • setup.py (1 hunks)

Walkthrough

This pull request updates the GitHub Actions workflow and package setup to include additional optional dependencies. The workflow file now installs extra skill sets by referencing new options. Additionally, new requirements files for Catalan, English, and Portuguese skills have been added or updated, and the setup.py has been modified to include these extras. No changes were made to the declarations of exported or public entities.

Changes

File(s) Change Summary
.github/.../build_tests.yml Updated the installation command to include three additional optional dependencies: skills-en, skills-ca, and skills-pt.
requirements/skills-ca.txt, requirements/skills-en.txt, requirements/skills-pt.txt Added new entries: a new file for Catalan skills (ovos-skill-fuster-quotes, ovos-skill-word-of-the-day) and updates to English and Portuguese files with ovos-skill-word-of-the-day.
setup.py Extended the extras_require dictionary with new entries linking 'skills-ca', 'skills-pt', and 'skills-en' to their respective requirements files.

Sequence Diagram(s)

sequenceDiagram
    participant CI as GitHub Actions (build_tests.yml)
    participant Setup as setup.py
    participant Req as Requirements Files
    CI->>Setup: Invoke installation command with new skill options
    Setup->>Req: Load requirements for skills-ca, skills-en, skills-pt
    Req-->>Setup: Return dependency lists
    Setup->>CI: Complete installation with additional skills
Loading

Suggested labels

fix

Suggested reviewers

  • j1nx
  • mikejgray
  • builderjer

Poem

I'm a hopping rabbit, light on my feet,
Code paths bloom where new skills meet.
Adding languages, one by one—what a sight!
In workflows and setups, everything feels just right.
With code and carrots, I celebrate this day,
Happy tunes and ASCII hops all the way!
🐇🌟


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.53%. Comparing base (23f0bab) to head (9a552bb).
Report is 209 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #662      +/-   ##
==========================================
- Coverage   75.33%   69.53%   -5.81%     
==========================================
  Files          15       15              
  Lines        3094     1671    -1423     
==========================================
- Hits         2331     1162    -1169     
+ Misses        763      509     -254     
Flag Coverage Δ
end2end 53.62% <ø> (?)
unittests 46.02% <ø> (-29.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JarbasAl JarbasAl merged commit f460bc0 into dev Mar 13, 2025
5 of 7 checks passed
@JarbasAl JarbasAl deleted the feat/lang_specific_skills branch March 13, 2025 03:29
@github-actions github-actions bot added feature and removed feature labels Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant