-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:improve_metrics_reporting #664
Conversation
ensure data is a json payload
WalkthroughThis pull request updates the intent matching process by enhancing metric reporting within the IntentService. It adds two distinct calls to Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant IntentService
participant MetricsServer
Client->>IntentService: Send utterance
IntentService->>IntentService: Check match type
alt PipelineMatch
IntentService->>IntentService: Call _upload_match_data (PipelineMatch)
else IntentHandlerMatch
IntentService->>IntentService: Call _upload_match_data (IntentHandlerMatch)
else No Match
IntentService->>IntentService: Call _upload_match_data (unmatched)
end
IntentService->>MetricsServer: Upload JSON serialized metrics data
Possibly related PRs
Suggested labels
Poem
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (7)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #664 +/- ##
==========================================
- Coverage 75.33% 69.59% -5.75%
==========================================
Files 15 15
Lines 3094 1674 -1420
==========================================
- Hits 2331 1165 -1166
+ Misses 763 509 -254
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ensure data is a json payload
Summary by CodeRabbit
New Features
Documentation