-
Notifications
You must be signed in to change notification settings - Fork 1
fix: i18n basePath for github pages #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis update introduces a significant enhancement to the way translation files are loaded in the application. By leveraging the document's Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (1)
- src/assets/i18n/loader.ts (1 hunks)
Additional comments not posted (1)
src/assets/i18n/loader.ts (1)
5-7
: The usage ofbasePath
inHttpLoaderFactory
is appropriate for dynamically determining the path for loading translation files. However, consider encapsulating the logic for determiningbasePath
within a function or theHttpLoaderFactory
itself to improve modularity and testability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Created a fix so that i18n path can be read using github pages
Main PR: #19
Summary by CodeRabbit
<base>
tag for more flexibility and accuracy.package.json
to remove an unnecessary newline at the end of the file.