Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle variables that have a branding suffix #779

Merged
merged 5 commits into from
Mar 10, 2025
Merged

Conversation

mauzey1
Copy link
Collaborator

@mauzey1 mauzey1 commented Mar 7, 2025

These changes will allow CMOR to process variables that have a "branding suffix" in their table entry name as defined in #762.

There are also minor fixes to error messages for whengrid_label or nominal_resolution are missing from the CV file.

@mauzey1 mauzey1 requested review from durack1 and taylor13 March 7, 2025 18:39
Copy link
Contributor

@durack1 durack1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mauzey1 great to see progress on this. I wonder how much does this depend on the format of CMIP7_CV.json in #778 - I am guessing it doesn't but just wanted to make sure

@taylor13 ping just FYI

@mauzey1
Copy link
Collaborator Author

mauzey1 commented Mar 10, 2025

@durack1 This change will only get the branded variable from the variable tables. It doesn't check the attributes extracted from it against the CV. I can update this PR this week to include checking the CV.

@taylor13
Copy link
Collaborator

regarding #779 (comment), I think there are only a few values in the cmor tables that also appear in the CV lists of the CMIP7_CV.json file and I don't think CMOR needs to check those. We can do those checks before putting a value of "approx_interval" or "realm" into a CMOR table.

We should, on the other hand check user input of such things as "source", "frequency", "region", etc. for consistency with the CVs. I think you're already doing that though. Right?

@mauzey1
Copy link
Collaborator Author

mauzey1 commented Mar 10, 2025

@taylor13 This PR will be merged to add the functionality for detecting the branding suffixes in variable names from the table and adding their values as global attributes. I will work on the CMIP7 checks in the next PR.

@mauzey1 mauzey1 merged commit fb9625a into main Mar 10, 2025
15 checks passed
@mauzey1 mauzey1 deleted the branded_variable branch March 10, 2025 18:01
@mauzey1 mauzey1 added this to the 3.10.0 milestone Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants