Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix query filtering of "\r" containing values in Solr #302

Merged
merged 5 commits into from
Nov 21, 2023
Merged

Fix query filtering of "\r" containing values in Solr #302

merged 5 commits into from
Nov 21, 2023

Conversation

alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented Nov 20, 2023 •
edited
Loading

@alexander-schranz alexander-schranz added bug Something isn't working Adapter: Solr Solr Adapter related issue labels Nov 20, 2023
This was referenced Nov 21, 2023
Closed
Closed
@alexander-schranz alexander-schranz changed the title Refactor testEqualConditionSpecialString handling Fix query filtering of "\r" containing values in Solr Nov 21, 2023
@alexander-schranz
Copy link
Member Author

Thx to @thomascorthals we could fix this issue via replacing \r\n and \r with \n this is working because we are in control how the data get indexed.

For more information see: solariumphp/solarium#1104 (comment)

@alexander-schranz alexander-schranz marked this pull request as ready for review November 21, 2023 22:15
@alexander-schranz alexander-schranz merged commit 459b80c into PHP-CMSIG:0.2 Nov 21, 2023
@alexander-schranz alexander-schranz deleted the bugfix/solr-filter branch November 21, 2023 22:17
@alexander-schranz alexander-schranz mentioned this pull request Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Adapter: Solr Solr Adapter related issue bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alexander-schranz