Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yii integration tests #437

Conversation

alexander-schranz
Copy link
Member

Downgrade yii-runner-http as in yiisoft/app branch. Else the server factory fails with:

  [Yiisoft\Di\NotFoundException] No definition or class found or resolvable for "Yiisoft\Yii\Runner\Http\ServerRequestFactory" while building "Yiisoft\Yii\Runner\Http\ServerRequestFactory".  

Also changed some code to use PSR Server Factory now.

@alexander-schranz alexander-schranz added bug Something isn't working Integration: Yii Yii related issue labels Oct 8, 2024
@alexander-schranz alexander-schranz merged commit 503db3a into PHP-CMSIG:0.6 Oct 8, 2024
30 of 32 checks passed
@alexander-schranz alexander-schranz deleted the bugfix/yii-integration-tests branch October 8, 2024 20:03
@@ -89,7 +89,7 @@
"yiisoft/yii-http": "^1.0",
"yiisoft/yii-middleware": "^1.0",
"yiisoft/yii-runner-console": "^2.0",
"yiisoft/yii-runner-http": "^2.0 || ^3.0",
"yiisoft/yii-runner-http": "^2.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samdark maybe you have a hint how we can keep compatibility here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Integration: Yii Yii related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant