-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tutorial_qnn_module_tf
after the deprecation of qml.qnn.KerasLayer
#1334
Conversation
👋 Hey, looks like you've updated some demos! 🐘 Don't forget to update the Please hide this comment once the field(s) are updated. Thanks! |
Thank you for opening this pull request. You can find the built site at this link. Deployment Info:
Note: It may take several minutes for updates to this pull request to be reflected on the deployed site. |
tutorial_qnn_module_tf
after the deprecation of KerasLayer
on PennyLane master branch
tutorial_qnn_module_tf
after the deprecation of KerasLayer
on PennyLane master branchtutorial_qnn_module_tf
after the deprecation of qml.qnn.KerasLayer
Thanks @JerryChen97. Rather than making this demo catch warnings, let's make it non-executable (will need to add codeblocks to represent the output like other non-executable demos). I've updated the warning in a comment to reflect this. |
Co-authored-by: Josh Izaac <josh146@gmail.com>
@josh146 I am checking |
This demo has three actual outputs. |
Co-authored-by: Isaac De Vlugt <34751083+isaacdevlugt@users.noreply.github.com>
Co-authored-by: Isaac De Vlugt <34751083+isaacdevlugt@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot Yushao! Hopefully this will fix the dev
branch before the release 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we uncomment the code now?
Co-authored-by: Christina Lee <chrissie.c.l@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates.
Context:
KerasLayer
has been already deprecated in PennyLane master branch (see PennyLaneAI/pennylane#7097). This PR updates thetutorial_qnn_module_tf
demo that relies onKerasLayer
inKeras2
.Summary:
Converted the mentioned demo into non-executable. As a result, the following changes to output were made:
_static
and show in the first outputAdded user warning on the top oftutorial_qnn_module_tf
.Inplace warning catchers for wherever theKerasLayer
was used.Relevant references:
Possible Drawbacks:
Related GitHub Issues:
[sc-86997]
If you are writing a demonstration, please answer these questions to facilitate the marketing process.
GOALS — Why are we working on this now?
Eg. Promote a new PL feature or show a PL implementation of a recent paper.
AUDIENCE — Who is this for?
Eg. Chemistry researchers, PL educators, beginners in quantum computing.
KEYWORDS — What words should be included in the marketing post?
Which of the following types of documentation is most similar to your file?
(more details here)