Remove javascript #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natewiebe13
force-pushed
the
remove-javascript
branch
from
5f8d208 to
2539044
Compare
Closed
|
Looks good! This makes things more easily manageable. Only question is would it make sense to include a composer script to build the icons? |
Yep! I plan on adding this with the automated updates PR. To keep the ball rolling, I'll merge this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22
You'll notice that I've restricted feather icons to the version we're currently using. This is to test out automated PR creation which will come in a later PR.
I have not add a replacement to
tests/prepare.jsas the tests will need a bit of an overhaul soon and we will revisit them.