Skip to content

fix: update code highlight #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 26, 2019
Merged

fix: update code highlight #206

merged 4 commits into from
Apr 26, 2019

Conversation

fsdiogo
Copy link
Collaborator

@fsdiogo fsdiogo commented Apr 24, 2019

@fsdiogo fsdiogo requested a review from terichadbourne April 24, 2019 13:44
@fsdiogo fsdiogo self-assigned this Apr 24, 2019
@fsdiogo fsdiogo mentioned this pull request Apr 24, 2019
@terichadbourne
Copy link
Member

@fsdiogo What's the best way for me to test this since the problem I was having is in my unmerged branch. Should I merge from your branch in progress into mine?

@fsdiogo
Copy link
Collaborator Author

fsdiogo commented Apr 24, 2019

I've tested in you branch, but we should merge from code. As this is a one line change, just copy-paste the change to your branch and see that it works 😛

@terichadbourne
Copy link
Member

@fsdiogo This is working for me now, but I'm curious... why does it do color coding the first time and not the second? Is that intentional? (see below without and with { long: true } in mfs lesson 4)

image

image

I've leave it to you to merge if you're comfortable with that outcome. (I'm not especially concerned about the colors in this context.)

@fsdiogo
Copy link
Collaborator Author

fsdiogo commented Apr 26, 2019

@terichadbourne I've found a more up-to-date package to highlight the logs and now everything is working properly:

1

2

@fsdiogo fsdiogo merged commit 035e8db into code Apr 26, 2019
@fsdiogo fsdiogo deleted the fix/update-code-highlight branch April 26, 2019 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants