Resolve bandit warnings #2379
Open
Resolve bandit warnings #2379
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2379 +/- ##
=======================================
Coverage 99.16% 99.16%
=======================================
Files 40 40
Lines 3101 3101
Branches 680 680
=======================================
Hits 3075 3075
Misses 15 15
Partials 11 11 🚀 New features to boost your workflow:
|
DanielNoord
approved these changes
Mar 5, 2025
staticdev
reviewed
Mar 17, 2025
kurtmckee
force-pushed
the
bandit-warnings
branch
from
860af9f to
3cde306
Compare
staticdev
requested changes
Mar 18, 2025
staticdev
reviewed
Mar 18, 2025
The `nosec` flags benefit from human-readable explanation, but bandit was seeing the trailing text and throwing warnings: ``` WARNING Test in comment: Needed is not a test name or id, ignoring WARNING Test in comment: for is not a test name or id, ignoring WARNING Test in comment: gitignore is not a test name or id, ignoring WARNING Test in comment: support is not a test name or id, ignoring ``` This is addressed by using another `#` character to hide the text.
staticdev
force-pushed
the
bandit-warnings
branch
from
2e26b8b to
e42578f
Compare
staticdev
approved these changes
Mar 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
nosecflags benefit from human-readable explanation, but bandit was seeing the trailing text and throwing warnings:This is addressed by using another
#character to hide the text.