Impl time crate into pyo3

[Owen-CH-Leung]

FIxes #4675

This MR integrates time crate into PyO3 ecosystem. It implements FromPyObject and IntoPyObject for the following structs from time crate:

• Date
• Duration
• Time
• OffsetDateTime
• PrimitiveDateTime
• UtcOffset

[bschoenmaeckers]

There is no implementation for UtcDateTime. Is that a oversight?

[Owen-CH-Leung]

There is no implementation for UtcDateTime. Is that a oversight?

I provided an implementation in earlier commits but I realized that the time crate 0.3.41 will break the msrv (since the time-core requires minimum rust version 1.67.1)

https://github.com/time-rs/time/blob/v0.3.41/time-core/Cargo.toml

I duno if breaking msrv is a good idea so I decided to downgrade time crate back to 0.3.20 to meet the msrv requirement. And then in 0.3.20 the struct UtcDateTime didn't exist so I've removed the impl.

Should I just bump the msrv and bring back UtcDateTime ?

[bschoenmaeckers]

It is OK to break the msrv in a optional feature. The jiff integration currently does the same thing (see #4823). Just make sure it is documented properly.

Further more forcing the time dependency to a fixed version is probably too invasive for users to be usable. So setting the minimum version to 0.3.38 should be sufficient.

[bschoenmaeckers]

Please document the new feature in the guide as well; https://pyo3.rs/latest/features.html.

[Owen-CH-Leung]

looks like main is broken ? @davidhewitt

[Icxolu]

Thanks! #5065 should have unblocked CI.

Similar to the addition of jiff you have to add the time feature in the noxfile so that the tests run in CI (because it can't be in full for MSRV reasons)

[bschoenmaeckers]

Can should use the utc_timezone function. https://pyo3.rs/main/doc/pyo3/types/fn.timezone_utc

[Owen-CH-Leung]

Thanks. I've switched to use timezone_utc function

[bschoenmaeckers]

Suggested change

	let is_utc = tzinfo
	.call_method1(
	"__eq__",
	(ob.py()
	.import("datetime")?
	.getattr(intern!(ob.py(), "timezone"))?
	.getattr(intern!(ob.py(), "utc"))?,),
	)?
	.extract::<bool>()?;
	let is_utc = tzinfo.eq(timezone_utc(py))?;

[Owen-CH-Leung]

Thanks & changed.

[bschoenmaeckers]

LGTM

[Icxolu]

Agreed! Thanks again 🚀