some more improvements #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tazend
commented
May 12, 2023
tazend
commented
- better testing for job submission
- fix some docstrings for JobSubmitDescription
tazend
added a commit
that referenced
this pull request
May 13, 2023
* set light/dark mode primary colors explicitly * Reuse logic to get the batch script of a job from the new Job API * improve job submit testing and fix bugs * JobSubmitDescription: fix some docstrings * change quality_of_service to just qos in pyslurm/db/job * fix date parse tests? (cherry picked from commit 42471d8)
tazend
added a commit
that referenced
this pull request
May 14, 2023
* set light/dark mode primary colors explicitly * Reuse logic to get the batch script of a job from the new Job API * improve job submit testing and fix bugs * JobSubmitDescription: fix some docstrings * change quality_of_service to just qos in pyslurm/db/job * fix date parse tests? (cherry picked from commit 42471d8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.