Remove the need to specify the RedeemerTag #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces friction for writing applications
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #178 +/- ##
==========================================
- Coverage 86.38% 86.23% -0.16%
==========================================
Files 26 26
Lines 2761 2767 +6
Branches 654 655 +1
==========================================
+ Hits 2385 2386 +1
- Misses 284 287 +3
- Partials 92 94 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
TODO I would rather set it to None, so that we catch situations where it is incorrectly initialized
nielstron
force-pushed
the
feat/derive_tag
branch
from
64e3c72 to
460d8ff
Compare
|
Thank you @nielstron for finding and removing this unnecessary complexity! Your change makes sense and it looks good to me. |
cffls
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces friction for writing applications.
Also the proposed way of specifying a redeemer tag = MINT for minting inputs is actually invalid. Mint scripts can only be invoked without datums, by specifying them as minting scripts.
Fixes #177