Support potential inputs in txbuilder #223
Conversation
This feature will allow users to define a list of potential utxo, which could be returned by a wallet, for UTxO selector to select inputs from.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #223 +/- ##
==========================================
+ Coverage 85.52% 85.71% +0.18%
==========================================
Files 26 26
Lines 2909 2919 +10
Branches 698 701 +3
==========================================
+ Hits 2488 2502 +14
+ Misses 310 307 -3
+ Partials 111 110 -1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
test/pycardano/test_txbuilder.py
Outdated
|
|
||
| utxos = chain_context.utxos(sender) | ||
|
|
||
| tx_builder.potential_inputs.append(utxos[1]) |
There was a problem hiding this comment.
Should we test here that not all inputs are chosen? This is the crucial property of potential inputs. I.e. maybe add two inputs such that the algorithm will never choose one of either because it does not contain the desired coin? Or choose a deterministic UTxO selection algo
There was a problem hiding this comment.
Yes, good point! Let me tweak this test a bit.
This feature will allow users to define a list of potential utxo, which could be returned by a wallet, for UTxO selector to select inputs from.
Addresses #204