Accept empty values for restoration #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #306 +/- ##
==========================================
+ Coverage 83.42% 83.53% +0.10%
==========================================
Files 28 28
Lines 3415 3413 -2
Branches 836 835 -1
==========================================
+ Hits 2849 2851 +2
+ Misses 416 414 -2
+ Partials 150 148 -2 ☔ View full report in Codecov by Sentry. |
nielstron
force-pushed
the
feat/allow_empty_deserialization
branch
from
caee8ac to
b4e1224
Compare
cffls
reviewed
Feb 20, 2024
nielstron
force-pushed
the
feat/allow_empty_deserialization
branch
from
8d45474 to
dbe5d22
Compare
cffls
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure why this is forbidden in the first place but it leads to failing deserializations of transactions with just lovelace and not native tokens attached (potentially just produced by cardano-cli > 8.x)