Skip to content

[bugfix] Set network value to 'mainnet' in blockfrost if only mainnet api url is provided #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

cffls
Copy link
Collaborator

@cffls cffls commented May 26, 2024

Fixes #349

Copy link

codecov bot commented May 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 83.56%. Comparing base (20e8ed7) to head (a580dff).

Files Patch % Lines
pycardano/backend/blockfrost.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #353      +/-   ##
==========================================
- Coverage   83.61%   83.56%   -0.05%     
==========================================
  Files          29       29              
  Lines        3722     3724       +2     
  Branches      939      940       +1     
==========================================
  Hits         3112     3112              
- Misses        445      447       +2     
  Partials      165      165              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cffls cffls added the bug fix Fixes a bug label May 26, 2024
@cffls cffls merged commit a2d9ac0 into Python-Cardano:main Jun 1, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: BlockFrostChainContext is not correctly initialized
1 participant