Skip to content

Fix min amount for collateral return #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 8, 2024
Merged

Conversation

cffls
Copy link
Collaborator

@cffls cffls commented Dec 7, 2024

This commit fixes errors "Minimum lovelace amount for collateral return x is greater than collateral change y". The root cause is that the collateral return can contain multi-assets that might exceed the minimum ADA required to hold them.

cffls added 2 commits December 7, 2024 13:51
This commit fixes errors "Minimum lovelace amount for collateral return x is greater than collateral change y".
The root cause is that the collateral return can contain multi-assets that might exceed the minimum ADA required to hold them.
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.68%. Comparing base (6c2d183) to head (5b42b60).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
- Coverage   85.74%   85.68%   -0.07%     
==========================================
  Files          32       32              
  Lines        4202     4204       +2     
  Branches     1052     1052              
==========================================
- Hits         3603     3602       -1     
- Misses        422      423       +1     
- Partials      177      179       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cffls cffls merged commit dfaa471 into Python-Cardano:main Dec 8, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant