Add unit tests to transaction.py #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacmota
commented
Dec 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #406 +/- ##
==========================================
+ Coverage 86.08% 86.40% +0.32%
==========================================
Files 32 32
Lines 4205 4201 -4
Branches 1049 1047 -2
==========================================
+ Hits 3620 3630 +10
+ Misses 408 399 -9
+ Partials 177 172 -5 ☔ View full report in Codecov by Sentry. |
nielstron
reviewed
Dec 13, 2024
pycardano/transaction.py
Outdated
| @@ -88,6 +90,8 @@ def normalize(self) -> Asset: | |||
| for k, v in list(self.items()): | |||
| if v == 0: | |||
| self.pop(k) | |||
|
|
|||
| # traceback.print_stack() | |||
There was a problem hiding this comment.
please remove this leftover comment and the corresponding import :)
There was a problem hiding this comment.
Thank you! Just removed.
|
Looks good, thank you for your contribution! Just a minor comment to address. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase test coverage for transaction.py