Skip to content

blockfrost Backend _get_script patches #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 1, 2025
Merged

Conversation

while0x1
Copy link
Contributor

@while0x1 while0x1 commented Mar 1, 2025

updated startsWith -> startswith, cast script_type[-1] to int for PlutusScript.from_version method

while0x1 added 2 commits March 1, 2025 09:00
cast script_type to int for the method PlutusScript.from_version
capitalisation mistake startswith in _gets_script
Copy link

codecov bot commented Mar 1, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.97%. Comparing base (af5ded0) to head (7bc531e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pycardano/backend/blockfrost.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #428   +/-   ##
=======================================
  Coverage   88.97%   88.97%           
=======================================
  Files          33       33           
  Lines        4744     4744           
  Branches     1134     1134           
=======================================
  Hits         4221     4221           
  Misses        368      368           
  Partials      155      155           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@cffls cffls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing it!

@cffls cffls merged commit 8211dee into Python-Cardano:main Mar 1, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants