Fix login error when two factor is disabled #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! Thanks for contributing! |
|
@Qluxzz: The README.md says "Since May 2018 two-factor authentication is required to log in" but then I noticed the non-2FA parts of avanza.py which led me to this PR from 2022. So 2FA is not required after all or what am I missing? Has the requirement changed over time? I thought once you go 2FA you don't go back :) |
|
@jonatanj I am unsure about the requirement, but I have a business account with Avanza which I still can login without 2fa. Maybe they have different rules for businesses. But that was the reason I needed this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When 2fa is disabled the response object is inside an extra level called "successfulLogin". Also security token was not saved as it was when using 2fa.