Warn only when n in not int in tauchen
#673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyamad
reviewed
Dec 19, 2022
quantecon/markov/approximation.py
Outdated
| " https://github.com/QuantEcon/QuantEcon.py/issues/663.", | ||
| UserWarning, stacklevel=2) | ||
|
|
||
| if not isinstance(n, int): |
There was a problem hiding this comment.
Suggested change
| if not isinstance(n, int): | |
| if not isinstance(n, numbers.Integral): |
isinstance(n, int) returns False for example if n is an np.int_:
>>> n = np.array([1])[0]
>>> type(n)
<class 'numpy.int64'>
>>> isinstance(n, int)
False
mmcky
reviewed
Dec 20, 2022
| @@ -19,8 +19,7 @@ def setup_method(self): | |||
| self.tol = 1e-12 | |||
| self.mu = 0. | |||
|
|
|||
| with pytest.warns(UserWarning): | |||
| mc = tauchen(self.n, self.rho, self.sigma, self.mu, self.n_std) | |||
| mc = tauchen(self.n, self.rho, self.sigma, self.mu, self.n_std) | |||
There was a problem hiding this comment.
@Smit-create maybe we can also test the warning when the old interface is used?
|
thanks @Smit-create I think this is a good approach 👍 |
mmcky
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QuantEcon/lecture-python.myst#296 (comment)