Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add javascript support #80

Merged
merged 2 commits into from
Aug 5, 2016
Merged

Add javascript support #80

merged 2 commits into from
Aug 5, 2016

Conversation

DonnieWest
Copy link
Contributor

By setting let g:tsuquyomi_javascript_support = 1 it will enable javascript support

@DonnieWest
Copy link
Contributor Author

This enables support for tsserver based completions with Javascript files. It's something I was fiddling around with locally, so feel free to take it or leave it. The biggest thing that doesn't work at the moment is the import functionality and I'm not sure of how to implement that while maintaining typescript functionality

This file could be more DRY, but currently this allows for removing things easily that may or may not work

@Quramy
Copy link
Owner

Quramy commented Aug 2, 2016

Thank you for your PR :)

I got the following error:

Error detected while processing tsuquyomi/ftplugin/javascript.vim:
line    8:
E121: Undefined variable: g:tsuquyomi_javascript_support
E15: Invalid expression: !g:tsuquyomi_javascript_support

You should check whether g:tsuquyomi_javascript_support exists. Please see https://github.com/Quramy/tsuquyomi/blob/master/plugin/tsuquyomi.vim#L22 .

@DonnieWest
Copy link
Contributor Author

@Quramy I think that fixes it, but I can verify a bit later :)

@DonnieWest
Copy link
Contributor Author

@Quramy yep, that seems to have fixed the issue 👍

Thanks for the feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants