Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use execvpe instead of execve in omnitrace-sample #187

Merged
merged 2 commits into from
Oct 27, 2022
Merged

Use execvpe instead of execve in omnitrace-sample #187

merged 2 commits into from
Oct 27, 2022

Conversation

jrmadsen
Copy link
Collaborator

  • previous implementation preferred exe in PATH over exe in PWD
  • 'p' variants of exec duplicate the actions of the shell in searching for an executable file if the specified filename does not contain a slash character

@jrmadsen
Use execvpe instead of execve in omnitrace-sample
44a8f74 
- previous implementation preferred exe in PATH over exe in PWD
- 'p' variants of exec duplicate the actions of the shell in searching for an executable file if the specified filename does not contain a slash character
@jrmadsen jrmadsen added bug fix Fixes a bug omnitrace-sample Involves the omnitrace-sample executable labels Oct 23, 2022
@jrmadsen jrmadsen added the testing Extends/improves/modifies testing label Oct 24, 2022
@jrmadsen jrmadsen merged commit 139070a into ROCm:main Oct 27, 2022
@jrmadsen jrmadsen deleted the omnitrace-sample-execvpe branch October 27, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug fix Fixes a bug omnitrace-sample Involves the omnitrace-sample executable testing Extends/improves/modifies testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jrmadsen