Skip to content

fix: set auth cookie url filter #2890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025
Merged

fix: set auth cookie url filter #2890

merged 1 commit into from
Feb 26, 2025

Conversation

hyoban
Copy link
Member

@hyoban hyoban commented Feb 26, 2025

Description

PR Type

  • Feature
  • Bugfix
  • Hotfix
  • Other (please describe):

Screenshots (if UI change)

Demo Video (if new feature)

Linked Issues

Additional context

Changelog

  • I have updated the changelog/next.md with my changes.

Copy link

vercel bot commented Feb 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
follow ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2025 2:05am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
follow-external-ssr ⬜️ Ignored (Inspect) Feb 26, 2025 2:05am

@follow-reviewer-bot
Copy link

Suggested PR Title:

feat(auth): add new API endpoints for authentication

Change Summary:
Added new API endpoints for authentication handling in index.ts.

Code Review:

  • File: apps/main/src/index.ts, Lines: 136-139
    Issue: The added wildcard patterns (?*) for the URLs may unintentionally match more URLs than intended, potentially creating security or functional concerns. Wildcard handling in URL matching can have broad implications if not strictly necessary.
    Change Request: Confirm and ensure that the wildcard behavior is absolutely required. If not, consider removing the ?* patterns and using more precise URL matching to avoid unintended matches. Additionally, check all handling of these routes to ensure no unintended side effects arise from this broader matching pattern.

No other issues requiring a change request were found.

@hyoban hyoban enabled auto-merge (squash) February 26, 2025 02:03
@hyoban hyoban merged commit a43b996 into dev Feb 26, 2025
10 checks passed
@hyoban hyoban deleted the fix/sign-in-url-filter branch February 26, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant