Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monitor: Fix dms to decimal degrees conversion #79

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

monitor: Fix dms to decimal degrees conversion #79

wants to merge 1 commit into from

Conversation

XePeleato
Copy link
Contributor

Actual algorithm does not work properly for negative values.

For example, if we input the value -54'15":

  • In the first loop it will set tval to -0.900
  • In the second loop it will add .004166 to that value, which is wrong.

This approach uses a variable to control if the value is negative.

@XePeleato
monitor: Fix dms to decimal degrees conversion
c17ecdc 
Actual algorithm does not work properly for negative values.

For example, if we input the value -54'15":
* In the first loop it will set tval to -0.900
* In the second loop it will add .004166 to that value, which is wrong.

This approach uses a variable to control if the value is negative.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@XePeleato