-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable unwind protection by default #1225
Conversation
Added the following fixes:
About the deprecation of the plugin, Also, a quick search shows only 7 results for this plugin, and one is Rcpp itself. So I could send patches to those 6 packages and there should be no trouble removing the plugin in the future. |
Catching up after a day in the country-side with a nine-hour power outage :) The plan with respect to patches to six packages sounds good -- you could follow the pattern in #1158 which set up a useful model. Not suggesting we must do that but I felt it helped and provided transparency. |
Fix error message expectation to comply with RcppCore/Rcpp/pull/1225
Yay! Thanks. I'll contact the maintainers of those packages that use the plugin to switch to the define instead, so that one day it can be safely removed. I'll document the process as suggested. |
As discussed, this PR enables unwind protection by default:
RCPP_USE_UNWIND_PROTECT
has no effect anymore.RCPP_NO_UNWIND_PROTECT
, similarly to otherRCPP_NO_*
defines.Checklist
R CMD check
still passes all tests