Skip to content

fix a bug belongs to bloomfilter's command bfInsert #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

631086083
Copy link
Contributor

fix a bug of bfInsert command
items = [1, 2, 3, 5, 6, 4]
arrs = r.bfInsert('bfin1', items, 100, 1e-4, None, 2, None)
when we use this code it returns the array [1,1,1,1,1,1,1,0] ;because when it run,it runs the command is “BF.INSERT bfin1 CAPPCITY 100 ERROR 0.0001 ITEMS 1 2 3 4 5 6 EXPANSION 2” the last two elementaries are keys which are inserted into bloomfilter and not work for expansion 。 the correct work command is “ BF.INSERT bfin1 CAPPCITY 100 ERROR 0.0001 EXPANSION 2 ITEMS 1 2 3 4 5 6” ,in that case ,the items must be at the end of params。

@gkorland gkorland requested a review from ashtul June 30, 2020 06:53
@ashtul ashtul merged commit 373eb6d into RedisBloom:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants