Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): Add desktop-text icon #972

Merged
merged 3 commits into from
Feb 11, 2023
Merged

feat(icons): Add desktop-text icon #972

merged 3 commits into from
Feb 11, 2023

Conversation

tiagoevanp
Copy link
Contributor

@tiagoevanp tiagoevanp commented Feb 1, 2023

Proposed changes (including videos or screenshots)

image

Issue(s)

Further comments

@tiagoevanp tiagoevanp requested a review from a team February 1, 2023 18:33
@ggazzo
Copy link
Member

ggazzo commented Feb 2, 2023

I'm not sure if the name is the best choice of words, could you explain me a little? this is suposed to be a screen with log?

@tiagoevanp
Copy link
Contributor Author

I'm not sure if the name is the best choice of words, could you explain me a little? this is suposed to be a screen with log?

log-view is the name of the icon included inside of icons package...

@tiagoevanp
Copy link
Contributor Author

I'm not sure if the name is the best choice of words, could you explain me a little? this is suposed to be a screen with log?

wait, I was thinking of PR's title... you are complaining about the icon name, right? Ok, I'm talking about that with design team!

@tiagoevanp tiagoevanp changed the title feat(icons): Add log-view icon feat(icons): Add desktop-text icon Feb 8, 2023
@tassoevan tassoevan merged commit 0183bbd into develop Feb 11, 2023
@tassoevan tassoevan deleted the new/log-view-icon branch February 11, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants