Remove librustrt, audio Task #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a macro expands to items, braces or a semicolon is now needed
Due to recent changes, librustrt and Task are now deprecated. Calling Rust from C should now "just work".
|
Please merge this as well :) |
|
Just got on lunch, will do it now and roll a release. |
AngryLawyer
added a commit
that referenced
this pull request
Dec 22, 2014
Remove librustrt, audio Task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
librustrt and Task have been removed: rust-lang/rust#19654. This pull request is pretty much only code removal.
Basically, no manual runtime initialization needs to be done when calling Rust from C anymore. It should now "just work".
With all that said and done, I do have some concerns that might be amended in the future:
thread "<unnamed>" panicked at "Noes", ...). There doesn't seem to be a way to set the name of a native thread yet.This is based off Gekkio's pull request #238, which hasn't been merged yet. :)
Probably a non-issue, but it might be best to accept their pull request first. I'm not quite sure what happens if a pull request includes someone else's pull request. :/