Debugfs #885
Open
Debugfs #885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamrk
commented
Sep 19, 2022
| let has_parent = parent.is_some(); | ||
| let name = name.as_char_ptr(); | ||
| let boxed1: Box<dyn Any> = Box::try_new(data)?; | ||
| let boxed2 = Box::try_new(boxed1)?; |
There was a problem hiding this comment.
Note that we're boxing twice here because Box<dyn Any> doesn't implement PointerWrapper since dyn Any is !Sized. I can look into making a Box-like PointerWrapper for unsized types if it would be generally useful.
Comment on lines
+91
to
+92
| let string = CString::try_from_fmt(fmt!("Debugfs file read count: {}\n", read_count))?; | ||
| data.write_slice(string.as_bytes())?; |
There was a problem hiding this comment.
Note that here we're first creating the CString and then copying it into the IoBufferWriter because I don't think we currently have a way to directly write format strings to an IoBufferWriter (unless I'm missing something?).
Add a Rust API to create directories and files in `debugfs`. Signed-off-by: Adam Bratschi-Kaye <ark.email@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-doing the
debugfsimplementation withoutseq_file.