Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry processing of messages until no change between runs #407

Merged
merged 21 commits into from
Jun 20, 2024

Conversation

stefpiatek
Copy link
Contributor

@stefpiatek stefpiatek commented May 30, 2024

closes #393

  • Allow env configuration of wait time for queues to empty before checking? Would be good to not wait during system tests

Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 88.60759% with 9 lines in your changes missing coverage. Please review.

Project coverage is 83.60%. Comparing base (de8ea69) to head (6e1b93a).

Files Patch % Lines
cli/src/pixl_cli/_message_processing.py 85.45% 8 Missing ⚠️
cli/src/pixl_cli/main.py 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
+ Coverage   83.04%   83.60%   +0.56%     
==========================================
  Files          76       81       +5     
  Lines        3061     3374     +313     
==========================================
+ Hits         2542     2821     +279     
- Misses        519      553      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@milanmlft milanmlft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a small suggestion/question regarding where --num-retries is/should be used.

@stefpiatek stefpiatek merged commit 3b51a85 into main Jun 20, 2024
10 checks passed
@stefpiatek stefpiatek deleted the peshence/cli-retry-processing branch June 20, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow CLI to retry processing until no new messages are exported
3 participants