-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move pixldc
commands into PIXL CLI
#411
Conversation
Doesn't seem to be used anywhere anymore
pixldc
commands into PIXL CLI
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #411 +/- ##
==========================================
- Coverage 83.26% 83.04% -0.22%
==========================================
Files 78 76 -2
Lines 3268 3061 -207
==========================================
- Hits 2721 2542 -179
+ Misses 547 519 -28 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking nice, adding in a couple of suggestions, we can try them out on the GAE this afternoon as well
This reverts commit 4ee36f5.
Reverted back to using
There's a couple of workarounds for this, like temporarily copying over the More importantly though, I think this points to some not-so-ideal design choices in the way we're handling these environment variables and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐ All working nicely on the GAE, though couldn't do dry run with the version of docker so tested out the prod volumes locally.
I think probably best to make just a pixl dc
subcommand which is a wrapper around a subprocess to docker compose
, as the aim is to make this an easier experience and then we don't have to document what the args are for docker compose etc.
Happy for you to merge once you've done that
Not necessarily for `up`, but for `down` it does
Fixes #392
pixl dc
CLI command as a wrapper arounddocker compose
pixldc
Periphery changes:
pixl-db
envvars fororthanc-anon
cli._utils