Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAuth2 implicit grant flow should use GET as default request method #49

Closed
aartek opened this issue Sep 7, 2018 · 0 comments · Fixed by #50
Closed

OAuth2 implicit grant flow should use GET as default request method #49

aartek opened this issue Sep 7, 2018 · 0 comments · Fixed by #50
Labels
bug Something isn't working

Comments

@aartek
Copy link
Contributor

aartek commented Sep 7, 2018

Description

Current implementation of Oauth2 implicit flow uses POST method. RFC says that default method supported by server must be GET, and optionally POST - https://tools.ietf.org/html/rfc6749#section-1.3.2

The authorization server MUST support the use of the HTTP "GET"
method [RFC2616] for the authorization endpoint and MAY support the
use of the "POST" method as well.

I think that client should be changed to use GET by default.
aartek added a commit to aartek/luigi that referenced this issue Sep 7, 2018
@aartek
SAP#49 [fix] OAuth2 implicit grant flow should use GET as default req…
e3c0d7c 
…uest method
@aartek aartek mentioned this issue Sep 7, 2018
Merged
@kwiatekus kwiatekus added bug Something isn't working area/luigi labels Sep 7, 2018
@kwiatekus kwiatekus added this to the Sprint_Swinka_0 milestone Sep 7, 2018
maxmarkus pushed a commit that referenced this issue Sep 7, 2018
@aartek @maxmarkus
#49 [fix] OAuth2 implicit grant flow should use GET as default reques… (
54b99ba 
#50)

* #49 [fix] OAuth2 implicit grant flow should use GET as default request method and be configurable with a config option
stanleychh pushed a commit to stanleychh/luigi that referenced this issue Dec 30, 2021
@aartek @maxmarkus
SAP#49 [fix] OAuth2 implicit grant flow should use GET as default req…
cb433a5 
…ues… (SAP#50)

* SAP#49 [fix] OAuth2 implicit grant flow should use GET as default request method and be configurable with a config option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#49 [fix] OAuth2 implicit grant flow should use GET as default reques… aartek/luigi
2 participants
@aartek @kwiatekus