Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calc max-height for tabNav dropdown #3572

Merged
merged 9 commits into from
Dec 11, 2023
Merged

calc max-height for tabNav dropdown #3572

merged 9 commits into from
Dec 11, 2023

Conversation

JohannesDoberer
Copy link
Contributor

fixes #3388

@JohannesDoberer JohannesDoberer added the bug Something isn't working label Dec 7, 2023
@ndricimrr ndricimrr assigned ndricimrr and unassigned ndricimrr Dec 8, 2023
@camelCaseChris camelCaseChris self-assigned this Dec 8, 2023
camelCaseChris
camelCaseChris reviewed Dec 8, 2023
View reviewed changes
Copy link
Contributor

@camelCaseChris camelCaseChris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it out locally, all worked as I would expect. Tried with/without breadcrumbs, with different tabNav settings, with additional drop-downs in the tabNav and also in mobile simulation. Scrolling worked.

Just one question in the code...

@JohannesDoberer JohannesDoberer merged commit 9819dea into main Dec 11, 2023
@JohannesDoberer JohannesDoberer deleted the height-tapNav-dropdown branch December 11, 2023 10:57
This was referenced Jan 23, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camelCaseChris camelCaseChris camelCaseChris approved these changes

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

@VincentUllal VincentUllal Awaiting requested review from VincentUllal VincentUllal is a code owner

Assignees

@camelCaseChris camelCaseChris

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

max-height and scroll for tabnav dropdown
3 participants
@JohannesDoberer @camelCaseChris @ndricimrr