1603 lazy loading option for compound web component mode #3590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camelCaseChris
requested review from
hardl,
JohannesDoberer,
ndricimrr and
VincentUllal
as code owners
| * @param {*} context the luigi node context | ||
| */ | ||
| renderWebComponentCompound(navNode, wc_container, extendedContext) { | ||
| const useLazyLoading = navNode.compound?.lazyLoadingOptions?.enabled === true; |
| }); | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
Please add a description to the function what it does.
| compoundItemContainer.style.height = temporaryContainerHeight; | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
Please add a description to the function what it does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
IntersectionObserverthat triggers the rendering when the container is visible. To support this, each compound item container is rendered with a temporary height, so that not all containers are immediately visible in the viewport.Discussion points:
compound.lazyLoadingOptions(object) options for lazy loading of the compound.enabled(boolean) to activate lazy loading mode.temporaryContainerHeight(CSS length string) height to apply as a default for all children of the compound. If not specified, a default fallback is used, currently "500px".intersectionRootMargin(CSS length string), to be passed on to the IntersectionObservercompound.children[].layoutConfig.temporaryContainerHeight(string) CSS height to apply to the individual children of the compound. Overrides the compound default.compound.lazyLoadingOptions.noTemporaryContainerHeightto suppress the setting/removing of the temporary height to the compound item containers.compound.temporaryContainerHeight?Known issues:
Related issue(s)
Fixes #1603.