Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor testing-utilities #3623

Merged
merged 16 commits into from
Feb 12, 2024
Merged

Refactor testing-utilities #3623

merged 16 commits into from
Feb 12, 2024

Conversation

JohannesDoberer
Copy link
Contributor

No description provided.

@JohannesDoberer JohannesDoberer marked this pull request as ready for review January 24, 2024 16:00
@JohannesDoberer
Copy link
Contributor Author

JohannesDoberer commented Jan 24, 2024 •
edited
Loading

Can be tested with following versions:

"@angular/animations": "^17.1.0",
.....
"@luigi-project/client-support-angular": "2.8.1-dev.202401241555",
    "@luigi-project/testing-utilities": "2.8.1-dev.202401241555",

@ndricimrr ndricimrr self-assigned this Jan 25, 2024
ndricimrr
ndricimrr approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected

@JohannesDoberer JohannesDoberer mentioned this pull request Jan 29, 2024
Closed
@JohannesDoberer JohannesDoberer merged commit e70621a into main Feb 12, 2024
@JohannesDoberer JohannesDoberer deleted the refactor-testing-utilities branch February 12, 2024 15:55
@JohannesDoberer JohannesDoberer added ora ora related issues bug Something isn't working enhancement New feature or request labels Feb 12, 2024
@JohannesDoberer JohannesDoberer mentioned this pull request Feb 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndricimrr ndricimrr ndricimrr approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@VincentUllal VincentUllal Awaiting requested review from VincentUllal VincentUllal is a code owner

@camelCaseChris camelCaseChris Awaiting requested review from camelCaseChris

Assignees

@ndricimrr ndricimrr

Labels
bug Something isn't working enhancement New feature or request ora ora related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohannesDoberer @ndricimrr