Skip to content

Add datatest-id to tabnav #3635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 12, 2024
Merged

Add datatest-id to tabnav #3635

merged 5 commits into from
Feb 12, 2024

Conversation

ndricimrr
Copy link
Contributor

@ndricimrr ndricimrr commented Feb 2, 2024

Description

Changes proposed in this pull request:

  • Added data-testid to TabNav.svelte
  • Refactored other data-testid instances since getTestId function was being duplicated

Related issue(s)

Fixes #3628

@JohannesDoberer JohannesDoberer self-assigned this Feb 5, 2024
@ndricimrr ndricimrr marked this pull request as ready for review February 7, 2024 13:13
@ndricimrr ndricimrr added the enhancement New feature or request label Feb 12, 2024
@ndricimrr ndricimrr merged commit 8dd650d into main Feb 12, 2024
@ndricimrr ndricimrr deleted the 3628-add-datatest-id-tabnav branch February 12, 2024 13:54
@JohannesDoberer JohannesDoberer mentioned this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add "data-testid" to tabnav entries
2 participants