Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TabNav navigate on click #3664

Merged
merged 55 commits into from
Apr 11, 2024
Merged

Add TabNav navigate on click #3664

merged 55 commits into from
Apr 11, 2024

Conversation

camelCaseChris
Copy link
Contributor

Description

Changes proposed in this pull request:
This PR includes these features from #3197:

  • If a TabNav child has category.navigateOnClick: true then the tab generated from that category can directly navigate to the path segment of that TabNav child. If several children have category.navigateOnClick: true for the same category label then the first child found will be used as the navigation target.

In addition, this PR includes the following:

  • The TabNav component now uses the newer "icon-tab-bar" component from Fundamental Styles. The previous "tabs" component is deprecated and does not support multi-click areas.
  • Other component and tests are adapted to the above change because e.g. they use selectors for classes that are now different.
  • Fixes a likely bug in FD about a tab item with multi-click area making the button to expand the menu unusable when the link of that item has focus.

Other features descibed in #3197 are not included in this PR, e.g. supporting TabNav children that are hidden or using string values for category.navigateOnClick.

Related issue(s)
Implements part of #3197.

@ndricimrr ndricimrr self-assigned this Mar 5, 2024
@ndricimrr ndricimrr changed the title 3197 TabNav navigate on click Add TabNav navigate on click Mar 5, 2024
@ndricimrr ndricimrr added the enhancement New feature or request label Mar 5, 2024
@ndricimrr ndricimrr marked this pull request as ready for review April 9, 2024 11:45
@ndricimrr ndricimrr merged commit f4a7e45 into main Apr 11, 2024
11 checks passed
@ndricimrr ndricimrr deleted the 3197-tabnav-navigate branch April 11, 2024 13:54
@JohannesDoberer JohannesDoberer mentioned this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants